trove pr guide

Trove PR Guide Overview This guide provides best practices for submitting, reviewing, and merging pull requests (PRs) in the Trove repository. Following these guidelines ensures smooth collaboration, code quality, and efficient workflows. Creating a Pull Request (PR) Before Submitting a PR Ensure your branch is up to date with the latest changes from main/master. Run tests locally (npm test, yarn test, etc.). Follow the projects coding standards (linting, formatting, etc.). Include unit/integration tests for new features or bug fixes. Write a clear and descriptive PR title (e.g., "Fix login button alignment" instead of "UI fix"). PR Description Template Reviewing a PR Reviewer Responsibilities Check for code quality (readability, maintainability). Ensure tests cover the changes. Verify functionality (test locally if needed). Look for security concerns (e.g., hardcoded secrets, SQL injection risks). Provide constructive feedback (be specific and kind). Approval Process At least 1-2 approvals from core maintainers before merging. If changes are requested, the PR author should update and re-request review. Use GitHubs "Approve", "Request Changes", or "Comment" options. Merging a PR Merge Strategies Squash & Merge (recommended for most cases keeps history clean). Rebase & Merge (if preserving individual commits is important). Merge Commit (only if explicitly required by the project). Post-Merge Steps Delete the merged branch (if applicable). Update any related documentation or changelogs. Notify stakeholders if the change affects deployments. Best Practices Small, Focused PRs (easier to review). Clear Commit Messages (use Conventional Commits). Automated Checks (CI/CD pipelines for tests & linting). Resolve Merge Conflicts Early. Avoid Force Pushing after review starts. Troubleshooting If CI fails, check logs and fix issues before re-running. If a PR is stuck, ping reviewers politely after 24-48 hours. For major changes, discuss in an issue before coding. Need Help? Ask in #dev (Slack/Discord) or tag @trove/maintainers. Happy Contributing!